Conversation
|
Review changes with Changed Files
|
peter-jerry-ye
force-pushed
the
zihang/fix-demangle
branch
2 times, most recently
from
8e8ba02 to
116b2e2
Compare
peter-jerry-ye
force-pushed
the
zihang/fix-demangle
branch
from
6410e06 to
b2c0ae5
Compare
peter-jerry-ye
force-pushed
the
zihang/fix-demangle
branch
from
3af9d48 to
9b9b827
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add proper rust and js implementation; add adquate tests.
The rational is that we'll have the JS implementation for test entry as well later on.
Metadata